Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with newer broker versions #804

Merged
merged 5 commits into from
Dec 30, 2021
Merged

Conversation

ods
Copy link
Collaborator

@ods ods commented Dec 12, 2021

Changes

Fixes #

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

@codecov
Copy link

codecov bot commented Dec 12, 2021

Codecov Report

Merging #804 (28c6739) into master (afe8820) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #804      +/-   ##
==========================================
+ Coverage   97.83%   97.87%   +0.03%     
==========================================
  Files          31       29       -2     
  Lines        5365     5218     -147     
==========================================
- Hits         5249     5107     -142     
+ Misses        116      111       -5     
Flag Coverage Δ
cext 88.30% <100.00%> (-0.23%) ⬇️
integration 97.83% <100.00%> (+0.03%) ⬆️
purepy 97.39% <100.00%> (+0.02%) ⬆️
unit 50.72% <75.00%> (-1.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiokafka/client.py 98.17% <100.00%> (+0.01%) ⬆️
aiokafka/consumer/fetcher.py 97.16% <100.00%> (+0.31%) ⬆️
aiokafka/producer/sender.py 98.68% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afe8820...28c6739. Read the comment docs.

@ods ods requested a review from tvoinarovskyi December 12, 2021 12:06
@tvoinarovskyi tvoinarovskyi merged commit 6b15132 into aio-libs:master Dec 30, 2021
@ods ods deleted the update_kafka branch December 30, 2021 10:48
multani added a commit to multani/aiokafka that referenced this pull request Dec 31, 2021
aio-libs#804 removed the
`aiokafka.protocol.produce` stubs imported from `kafka-python`, this
caused the documentation to fail to build.
multani added a commit to multani/aiokafka that referenced this pull request Dec 31, 2021
aio-libs#804 removed the
`aiokafka.protocol.produce` stubs imported from `kafka-python`, this
caused the documentation to fail to build.
ods pushed a commit that referenced this pull request Dec 31, 2021
* Fix doc building

#804 removed the
`aiokafka.protocol.produce` stubs imported from `kafka-python`, this
caused the documentation to fail to build.

* Fix RTD doc compilation

#810 imports errors from
`setuptools` instead of `distutils`

This is available only starting from `setuptools` v59.0.0
(pypa/setuptools#2858) but RTD currently
defaults to v58.2.0
(https://docs.readthedocs.io/en/stable/builds.html#python)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants