Skip to content

Commit

Permalink
Test with newer versions in CI
Browse files Browse the repository at this point in the history
  • Loading branch information
ods committed Dec 30, 2021
1 parent d208617 commit 28c6739
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 12 deletions.
30 changes: 21 additions & 9 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -220,21 +220,21 @@ jobs:
matrix:
include:
- python: 3.9
kafka: "2.4.0"
scala: "2.12"
kafka: "2.8.1"
scala: "2.13"

# Older python versions against latest broker
- python: 3.6
kafka: "2.4.0"
scala: "2.12"
kafka: "2.8.1"
scala: "2.13"
- python: 3.7
kafka: "2.4.0"
scala: "2.12"
kafka: "2.8.1"
scala: "2.13"
- python: 3.8
kafka: "2.4.0"
scala: "2.12"
kafka: "2.8.1"
scala: "2.13"

# Older brokers against latest python version
# Older/newer brokers against latest python version
- python: 3.9
kafka: "0.9.0.1"
scala: "2.11"
Expand All @@ -256,6 +256,18 @@ jobs:
- python: 3.9
kafka: "2.3.1"
scala: "2.12"
- python: 3.9
kafka: "2.4.1"
scala: "2.12"
- python: 3.9
kafka: "2.5.1"
scala: "2.12"
- python: 3.9
kafka: "2.6.3"
scala: "2.12"
- python: 3.9
kafka: "2.7.2"
scala: "2.13"
fail-fast: false

steps:
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Some simple testing tasks (sorry, UNIX only).

FLAGS?=--maxfail=3
SCALA_VERSION?=2.12
KAFKA_VERSION?=2.2.2
SCALA_VERSION?=2.13
KAFKA_VERSION?=2.8.1
DOCKER_IMAGE=aiolibs/kafka:$(SCALA_VERSION)_$(KAFKA_VERSION)
DIFF_BRANCH=origin/master
FORMATTED_AREAS=aiokafka/util.py aiokafka/structs.py
Expand Down
5 changes: 4 additions & 1 deletion tests/test_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@
from aiokafka.client import AIOKafkaClient, ConnectionGroup, CoordinationType
from aiokafka.conn import AIOKafkaConnection, CloseReason
from aiokafka.util import create_task, get_running_loop
from ._testutil import KafkaIntegrationTestCase, run_until_complete
from ._testutil import (
KafkaIntegrationTestCase, run_until_complete, kafka_versions
)


NO_ERROR = 0
Expand Down Expand Up @@ -288,6 +290,7 @@ async def test_send_request(self):
self.assertTrue(isinstance(resp, MetadataResponse))
await client.close()

@kafka_versions('<2.6') # FIXME Not implemented yet
@run_until_complete
async def test_check_version(self):
kafka_version = tuple(int(x) for x in self.kafka_version.split("."))
Expand Down

0 comments on commit 28c6739

Please sign in to comment.