Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of custom URL, use yarl.URL.build instead #2051

Merged
merged 2 commits into from
Jul 3, 2017
Merged

Get rid of custom URL, use yarl.URL.build instead #2051

merged 2 commits into from
Jul 3, 2017

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Jul 3, 2017

Fix for #2048

@codecov-io
Copy link

Codecov Report

Merging #2051 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2051      +/-   ##
==========================================
+ Coverage   97.05%   97.08%   +0.03%     
==========================================
  Files          38       38              
  Lines        7701     7684      -17     
  Branches     1348     1343       -5     
==========================================
- Hits         7474     7460      -14     
+ Misses        103      102       -1     
+ Partials      124      122       -2
Impacted Files Coverage Δ
aiohttp/http_writer.py 94.52% <ø> (+0.94%) ⬆️
aiohttp/http_parser.py 97.23% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c705f13...b2adf2d. Read the comment docs.

@asvetlov asvetlov merged commit fd71bc2 into master Jul 3, 2017
@asvetlov asvetlov deleted the url branch July 3, 2017 15:02
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asvetlov @codecov-io