Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some flaky tests #7896

Merged
merged 1 commit into from
Nov 25, 2023
Merged

Fix some flaky tests #7896

merged 1 commit into from
Nov 25, 2023

Conversation

Dreamsorcerer
Copy link
Member

No description provided.

@Dreamsorcerer Dreamsorcerer added bot:chronographer:skip This PR does not need to include a change note backport-3.9 labels Nov 25, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 25, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6f54953) 97.40% compared to head (515c898) 97.40%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #7896   +/-   ##
=======================================
  Coverage   97.40%   97.40%           
=======================================
  Files         107      107           
  Lines       32237    32246    +9     
  Branches     3749     3750    +1     
=======================================
+ Hits        31401    31410    +9     
  Misses        632      632           
  Partials      204      204
Flag Coverage Δ
CI-GHA 97.32% <100.00%> (+<0.01%) ⬆️
OS-Linux 96.99% <100.00%> (+<0.01%) ⬆️
OS-Windows 95.48% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.80% <100.00%> (-0.01%) ⬇️
Py-3.10.11 95.41% <88.88%> (-0.01%) ⬇️
Py-3.10.13 96.79% <88.88%> (-0.01%) ⬇️
Py-3.11.6 96.50% <88.88%> (-0.04%) ⬇️
Py-3.12.0 96.60% <100.00%> (+0.02%) ⬆️
Py-3.8.10 95.37% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.72% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 95.37% <100.00%> (+<0.01%) ⬆️
Py-3.9.18 96.76% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.13 96.22% <100.00%> (+<0.01%) ⬆️
VM-macos 96.80% <100.00%> (-0.01%) ⬇️
VM-ubuntu 96.99% <100.00%> (+<0.01%) ⬆️
VM-windows 95.48% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit 9a7cfe7 into master Nov 25, 2023
31 of 34 checks passed
@Dreamsorcerer Dreamsorcerer deleted the fix-flaky branch November 25, 2023 20:31
@patchback Patchback
Copy link
Contributor

patchback bot commented Nov 25, 2023 •
edited
Loading

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/9a7cfe77623b9a61e4e58f425fff99529de2f795/pr-7896

Backported as #7900

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 25, 2023
@Dreamsorcerer @patchback
Fix some flaky tests (#7896)
633dcb9 
(cherry picked from commit 9a7cfe7)
@patchback patchback bot mentioned this pull request Nov 25, 2023
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Nov 25, 2023 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/9a7cfe77623b9a61e4e58f425fff99529de2f795/pr-7896

Backported as #7901

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 25, 2023
@Dreamsorcerer @patchback
Fix some flaky tests (#7896)
9c75ae7 
(cherry picked from commit 9a7cfe7)
@patchback patchback bot mentioned this pull request Nov 25, 2023
Merged
Dreamsorcerer added a commit that referenced this pull request Nov 25, 2023
@patchback @Dreamsorcerer
[PR #7896/9a7cfe77 backport][3.9] Fix some flaky tests (#7900)
ddc2a26 
**This is a backport of PR #7896 as merged into master
(9a7cfe7).**

Co-authored-by: Sam Bull <[email protected]>
Dreamsorcerer added a commit that referenced this pull request Nov 25, 2023
@patchback @Dreamsorcerer
[PR #7896/9a7cfe77 backport][3.10] Fix some flaky tests (#7901)
a3fa775 
**This is a backport of PR #7896 as merged into master
(9a7cfe7).**

Co-authored-by: Sam Bull <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Dreamsorcerer