Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid duplicating of web.Application and web.Request #602

Closed
asvetlov opened this issue Oct 28, 2015 · 3 comments
Closed

Forbid duplicating of web.Application and web.Request #602

asvetlov opened this issue Oct 28, 2015 · 3 comments
Labels
good first issue Good for newcomers outdated
Milestone
0.19

Comments

@asvetlov
Copy link
Member

I've found both Application and Request has .copy() method with unpredictable behavior.
We should forbid this one.

There are two options:

  1. Don't inherit web.Application and web.Request from dict but implement MutableMapping abc from scratch.
  2. Override .copy with raising NotImplementedErrorr exception.

I'm inclining to second choice.

The patch is trivial but requires two additional tests in our suite and docs change.

Any volunteers?
@asvetlov asvetlov added the good first issue Good for newcomers label Oct 28, 2015
@asvetlov asvetlov added this to the 0.19 milestone Oct 28, 2015
@jashandeep-sohi
Copy link
Contributor

I'll make a PR with option 2.

@asvetlov
Copy link
Member Author

Thanks

@jashandeep-sohi jashandeep-sohi mentioned this issue Oct 28, 2015
Merged
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers outdated
Projects
None yet
Milestone
0.19
Development

No branches or pull requests
2 participants
@asvetlov @jashandeep-sohi