-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added typing to examples #5256
Added typing to examples #5256
Conversation
…oop is deprecated
I do not know what kind of change I should add in |
This pull request introduces 4 alerts when merging 9f08ad1 into 37d2376 - view on LGTM.com new alerts:
|
I think we don't need a CHANGES file for this PR but the linter check should be green. |
I am on it, a new commit is coming |
This pull request introduces 1 alert and fixes 1 when merging c3dc373 into 5357858 - view on LGTM.com new alerts:
fixed alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #5256 +/- ##
=======================================
Coverage 97.54% 97.54%
=======================================
Files 43 43
Lines 8794 8794
Branches 1413 1415 +2
=======================================
Hits 8578 8578
Misses 101 101
Partials 115 115
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This pull request fixes 1 alert when merging e63ef8b into 5357858 - view on LGTM.com fixed alerts:
|
Thanks! |
I forgot to create a pull request for this, I do not know if it is welcome or useful by any means.
I fell that people would start using types more often, it saves us from some difficult to find bugs, so why not show it.
What do these changes do?
Add type hints to examples so that it is easier to get up and going with typed code
Are there changes in behavior for the user?
Not really
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.