Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser of the Forwarded header ignores the port number #3009

Closed
gjcarneiro opened this issue May 17, 2018 · 2 comments
Closed

Parser of the Forwarded header ignores the port number #3009

gjcarneiro opened this issue May 17, 2018 · 2 comments
Labels
bug outdated server

Comments

@gjcarneiro
Copy link
Contributor

Long story short

Parser of the Forwarded header ignores the port number.

Expected behaviour

Parsing the header Forwarded: for=1.2.3.4:5678 should yield a request.forwarded value of ({"for": "1.2.3.4:5678"},).

Actual behaviour

Parsing the header Forwarded: for=1.2.3.4:5678 gives me request.forwarded value of ({"for": "1.2.3.4"},). That is, it removes the client port number.

Your environment

aiohttp 3.2.1 / Python 3.6.5.
@asvetlov
Copy link
Member

Good finding!
Would you make a pull request?

gjcarneiro pushed a commit to gjcarneiro/aiohttp that referenced this issue May 18, 2018
Don't throw away port number when parsing the Forwarded header aio-li…
e382c67 
…bs#3009
@gjcarneiro gjcarneiro mentioned this issue May 18, 2018
Merged
5 tasks
gjcarneiro pushed a commit to gjcarneiro/aiohttp that referenced this issue May 18, 2018
Don't throw away port number when parsing the Forwarded header aio-li…
faf71a1 
…bs#3009
gjcarneiro pushed a commit to gjcarneiro/aiohttp that referenced this issue May 18, 2018
Don't throw away port number when parsing the Forwarded header aio-li…
439474a 
…bs#3009
gjcarneiro pushed a commit to gjcarneiro/aiohttp that referenced this issue May 18, 2018
Don't throw away port number when parsing the Forwarded header aio-li…
693423d 
…bs#3009
asvetlov pushed a commit that referenced this issue May 18, 2018
@gjcarneiro @asvetlov
Don't throw away port number when parsing the Forwarded header #3009 (#…
bf058ef 
…3013)
@dependencies dependencies bot mentioned this issue Jun 2, 2018
Closed
kornicameister referenced this issue in kornicameister/korni-stats-collector Jun 7, 2018
@pyup-bot @kornicameister
Update aiohttp to 3.3.1 (#78)
74c1f03 
This PR updates [aiohttp](https://pypi.org/project/aiohttp) from **3.2.1** to **3.3.1**.



<details>
  <summary>Changelog</summary>
  
  
   ### 3.3.0
   ```
   ==================

Features
--------

- Raise ``ConnectionResetError`` instead of ``CancelledError`` on trying to
  write to a closed stream. (`2499 &lt;https://github.com/aio-libs/aiohttp/pull/2499&gt;`_)
- Implement ``ClientTimeout`` class and support socket read timeout. (`2768 &lt;https://github.com/aio-libs/aiohttp/pull/2768&gt;`_)
- Enable logging when ``aiohttp.web`` is used as a program (`2956 &lt;https://github.com/aio-libs/aiohttp/pull/2956&gt;`_)
- Add canonical property to resources (`2968 &lt;https://github.com/aio-libs/aiohttp/pull/2968&gt;`_)
- Forbid reading response BODY after release (`2983 &lt;https://github.com/aio-libs/aiohttp/pull/2983&gt;`_)
- Implement base protocol class to avoid a dependency from internal
  ``asyncio.streams.FlowControlMixin`` (`2986 &lt;https://github.com/aio-libs/aiohttp/pull/2986&gt;`_)
- Cythonize ``helpers.reify``, 5% boost on macro benchmark (`2995 &lt;https://github.com/aio-libs/aiohttp/pull/2995&gt;`_)
- Optimize HTTP parser (`3015 &lt;https://github.com/aio-libs/aiohttp/pull/3015&gt;`_)
- Implement ``runner.addresses`` property. (`3036 &lt;https://github.com/aio-libs/aiohttp/pull/3036&gt;`_)
- Use ``bytearray`` instead of a list of ``bytes`` in websocket reader. It
  improves websocket message reading a little. (`3039 &lt;https://github.com/aio-libs/aiohttp/pull/3039&gt;`_)
- Remove heartbeat on closing connection on keepalive timeout. The used hack
  violates HTTP protocol. (`3041 &lt;https://github.com/aio-libs/aiohttp/pull/3041&gt;`_)
- Limit websocket message size on reading to 4 MB by default. (`3045 &lt;https://github.com/aio-libs/aiohttp/pull/3045&gt;`_)


Bugfixes
--------

- Don&#39;t reuse a connection with the same URL but different proxy/TLS settings
  (`2981 &lt;https://github.com/aio-libs/aiohttp/pull/2981&gt;`_)
- When parsing the Forwarded header, the optional port number is now preserved.
  (`3009 &lt;https://github.com/aio-libs/aiohttp/pull/3009&gt;`_)


Improved Documentation
----------------------

- Make Change Log more visible in docs (`3029 &lt;https://github.com/aio-libs/aiohttp/pull/3029&gt;`_)
- Make style and grammar improvements on the FAQ page. (`3030 &lt;https://github.com/aio-libs/aiohttp/pull/3030&gt;`_)
- Document that signal handlers should be async functions since aiohttp 3.0
  (`3032 &lt;https://github.com/aio-libs/aiohttp/pull/3032&gt;`_)


Deprecations and Removals
-------------------------

- Deprecate custom application&#39;s router. (`3021 &lt;https://github.com/aio-libs/aiohttp/pull/3021&gt;`_)


Misc
----

- 3008, 3011
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/aiohttp
  - Changelog: https://pyup.io/changelogs/aiohttp/
  - Repo: https://github.com/aio-libs/aiohttp
</details>
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug outdated server
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asvetlov @gjcarneiro