Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytest-aiohttp: compatibility with pytest v3.3.0 #2565

Closed
popravich opened this issue Nov 28, 2017 · 4 comments
Closed

pytest-aiohttp: compatibility with pytest v3.3.0 #2565

popravich opened this issue Nov 28, 2017 · 4 comments
Labels
need pull request outdated

Comments

@popravich
Copy link
Member

Long story short

pytest-dev/pytest#2959
Fixture parameters are now immutable, pytest_plugin.py need to be updated
@asvetlov asvetlov mentioned this issue Nov 29, 2017
Closed
asvetlov added a commit that referenced this issue Nov 29, 2017
@asvetlov
Fix #2565: Fix compatibility with pytest 3.3+
893f0c9
@asvetlov asvetlov mentioned this issue Nov 29, 2017
Merged
asvetlov added a commit that referenced this issue Nov 29, 2017
@asvetlov
Fix compatibility with pytest 3.3+ (#2573)
c713b57 
* Fix #2565: Fix compatibility with pytest 3.3+

* Polish docstring

* Fix coverage plugin

* Disable coverage blame
@asvetlov
Copy link
Member

Fixed by #2573

@argaen
Copy link
Member

argaen commented Nov 30, 2017

Would it make sense to put code into pytest-aiohttp package? In cases like this, a new release of aiohttp is needed and not all the users are prepared to upgrade their aiohttp version just to use the latest pytest.

So for now, either users have to live with this until they upgrade or this could be backported to previous versions. IMO having this separated in pytest-aiohttp would make life easier

@asvetlov
Copy link
Member

pytest-aiohttp is tightly coupled with aiohttp itself.
Keeping everything in the single code base simplifies testing aiohttp itself and checking that everything is working without problems.
Introduced pitfall requires a new pytest-aiohttp release though just to note people that problem is fixed.

Anyway pytest-aiohttp provides guarantee for the latest aiohttp only (the same policy as for aiohttp-session and other libs. Supporting a matrix of compatible versions is nightmare.

This was referenced Mar 15, 2018
Closed
Closed
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
need pull request outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@popravich @asvetlov @argaen