Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write a topic about on_startup/on_shutdown signals usage for handling objects like DB connections #2131

Closed
asvetlov opened this issue Jul 26, 2017 · 2 comments
Labels
documentation Improvements or additions to documentation outdated
Milestone

Comments

@asvetlov
Copy link
Member

Now http://aiohttp.readthedocs.io/en/stable/web.html has signals chapter but it mentions on_prepare only: http://aiohttp.readthedocs.io/en/stable/web.html#signals
There are another topics about graceful shutdown: http://aiohttp.readthedocs.io/en/stable/web.html#graceful-shutdown and background tasks: http://aiohttp.readthedocs.io/en/stable/web.html#background-tasks

But we need explicit topic for pointing on redis/postgres/whatever initialization/cleaning-up.

See also https://stackoverflow.com/questions/45134300/aioredis-aiohttp-proper-usage-of-connection-pooling

@asvetlov asvetlov added the documentation Improvements or additions to documentation label Jul 26, 2017
@asvetlov asvetlov added this to the 2.3.0 milestone Jul 26, 2017
@asvetlov
Copy link
Member Author

asvetlov commented Oct 9, 2017

Done by #2196

@asvetlov asvetlov closed this as completed Oct 9, 2017
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation outdated
Projects
None yet
Development

No branches or pull requests

1 participant