Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken interface for response.url #1292

Closed
wumpus opened this issue Oct 6, 2016 · 4 comments
Closed

broken interface for response.url #1292

wumpus opened this issue Oct 6, 2016 · 4 comments
Labels

Comments

@wumpus
Copy link

wumpus commented Oct 6, 2016

The docs say that response.url is a string, but, it's currently yarl.URL ... I see that the conversion to using yarl is new?

While I'm in there, can I note that response.host is useless, because it doesn't have a port? At best it's a misleading interface.

@asvetlov
Copy link
Member

asvetlov commented Oct 6, 2016

Docs reflects the latest release but response.url became a yarl.URL in master only.
Maybe it's wrong idea and yarl.URL property should have own name.
I didn't polish the API yet.
Suggestions? resp.url_obj looks ugly.

Agree about host.

@wumpus
Copy link
Author

wumpus commented Oct 6, 2016

Changing the interface after 1.0, not so nice!

I agree resp.url_obj is a little ugly, but I can't think of a better name. I do like the idea of access to an object, because I have a crawler which sometimes spends a lot of cpu time manipulating urls.

@asvetlov
Copy link
Member

asvetlov commented Oct 7, 2016

Fixed by #1295

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants