-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
broken interface for response.url #1292
Comments
Docs reflects the latest release but Agree about |
Changing the interface after 1.0, not so nice! I agree resp.url_obj is a little ugly, but I can't think of a better name. I do like the idea of access to an object, because I have a crawler which sometimes spends a lot of cpu time manipulating urls. |
Fixed by #1295 |
The docs say that response.url is a string, but, it's currently yarl.URL ... I see that the conversion to using yarl is new?
While I'm in there, can I note that response.host is useless, because it doesn't have a port? At best it's a misleading interface.
The text was updated successfully, but these errors were encountered: