Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish ClientSession.loop property #1149

Closed
asvetlov opened this issue Sep 10, 2016 · 3 comments
Closed

Publish ClientSession.loop property #1149

asvetlov opened this issue Sep 10, 2016 · 3 comments

Comments

@asvetlov
Copy link
Member

web.Application.loop is very handy -- all server code has access to application instance and therefore loop is not need to be tediously passed into every function call.

Let's implement the same for client session.

@Kentzo
Copy link

Kentzo commented Sep 13, 2016

@asvetlov I think this feature request may be related to this task: http://bugs.python.org/issue26969

@asvetlov
Copy link
Member Author

No. I recommend to pass loop explicitly everywhere.
The property is just convenient helper allowing to not pass loop along with ClientSession because the session already has a reference to loop inside.

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants