You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A future PR should remove allowed_protocol_schema_set in BaseConnector as its only there for backwards compat
> It looks like the aiodocker is already doing that, I see in the code:
We're aware of that. The point is that currently the client just tries a whitelist of protocols, but really the whitelist should depend which connector is being used (http:// won't work if UnixConnector is used, for example).
I guess tcp:// should be added to the list? I'm not aware of this being a recognised URL protocol though, so not sure why that is in use..
bdraco
changed the title
Adjust to only allow unix:// urls when the UnixConnector is used which should not be backported since its a breaking change.
Remove allowed_protocol_schema_set backwards compat in BaseConnectorAug 7, 2024
As a followup to #8632 (ref #8600)
A future PR should remove
allowed_protocol_schema_set
inBaseConnector
as its only there for backwards compatWe're aware of that. The point is that currently the client just tries a whitelist of protocols, but really the whitelist should depend which connector is being used (http:// won't work if UnixConnector is used, for example).
I guess tcp:// should be added to the list? I'm not aware of this being a recognised URL protocol though, so not sure why that is in use..
Originally posted by @Dreamsorcerer in #8600 (comment)
The text was updated successfully, but these errors were encountered: