Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation for running complex applications #6278

Merged
merged 7 commits into from
Nov 12, 2021
Merged

Improve documentation for running complex applications #6278

merged 7 commits into from
Nov 12, 2021

Conversation

Dreamsorcerer
Copy link
Member

From discussion at #5572.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 9, 2021
@codecov
Copy link

codecov bot commented Nov 9, 2021 •
edited
Loading

Codecov Report

Merging #6278 (8c9c6a9) into master (2080708) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6278   +/-   ##
=======================================
  Coverage   93.30%   93.30%           
=======================================
  Files         103      103           
  Lines       30362    30362           
  Branches     2729     2729           
=======================================
  Hits        28328    28328           
  Misses       1857     1857           
  Partials      177      177
Flag Coverage Δ
unit 93.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2080708...8c9c6a9. Read the comment docs.

asvetlov
asvetlov approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asvetlov
Copy link
Member

Let's backport to make it visible by the next bugfix release.

@Dreamsorcerer Dreamsorcerer merged commit 32d715b into master Nov 12, 2021
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-3 branch November 12, 2021 00:27
@patchback
Copy link
Contributor

patchback bot commented Nov 12, 2021 •
edited
Loading

Backport to 3.8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.8/32d715b633c27fbe61ce11bd423e85d0972e1f40/pr-6278

Backported as #6299

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 12, 2021
@Dreamsorcerer
Improve documentation for running complex applications (#6278)
3170489 
(cherry picked from commit 32d715b)
@patchback patchback bot mentioned this pull request Nov 12, 2021
Merged
@patchback
Copy link
Contributor

patchback bot commented Nov 12, 2021 •
edited
Loading

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/32d715b633c27fbe61ce11bd423e85d0972e1f40/pr-6278

Backported as #6300

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 12, 2021
@Dreamsorcerer
Improve documentation for running complex applications (#6278)
13a7af1 
(cherry picked from commit 32d715b)
@patchback patchback bot mentioned this pull request Nov 12, 2021
Merged
Dreamsorcerer added a commit that referenced this pull request Nov 12, 2021
@patchback @Dreamsorcerer
Improve documentation for running complex applications (#6278) (#6299)
c4502b0 
(cherry picked from commit 32d715b)

Co-authored-by: Sam Bull <[email protected]>
Dreamsorcerer added a commit that referenced this pull request Nov 12, 2021
@patchback @Dreamsorcerer
Improve documentation for running complex applications (#6278) (#6300)
a603c5e 
(cherry picked from commit 32d715b)

Co-authored-by: Sam Bull <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dreamsorcerer @asvetlov