Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify tiny timeouts behavior and how it can affect performance #6274

Merged
merged 5 commits into from
Nov 12, 2021
Merged

Clarify tiny timeouts behavior and how it can affect performance #6274

merged 5 commits into from
Nov 12, 2021

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Nov 8, 2021

See also #6008

@asvetlov asvetlov requested a review from webknjaz as a code owner November 8, 2021 12:56
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 8, 2021
webknjaz
webknjaz reviewed Nov 8, 2021
View reviewed changes
CHANGES/6274.doc.rst Outdated Show resolved Hide resolved
@asvetlov asvetlov enabled auto-merge (squash) November 12, 2021 10:47
@codecov
Copy link

codecov bot commented Nov 12, 2021 •
edited
Loading

Codecov Report

Merging #6274 (7baf1ee) into master (d969116) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6274   +/-   ##
=======================================
  Coverage   93.30%   93.30%           
=======================================
  Files         103      103           
  Lines       30362    30362           
  Branches     2729     2729           
=======================================
  Hits        28328    28328           
  Misses       1857     1857           
  Partials      177      177
Flag Coverage Δ
unit 93.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/locks.py 92.85% <0.00%> (ø)
aiohttp/client.py 24.56% <0.00%> (ø)
aiohttp/helpers.py 96.92% <0.00%> (ø)
aiohttp/streams.py 97.45% <0.00%> (ø)
aiohttp/tracing.py 100.00% <0.00%> (ø)
aiohttp/formdata.py 98.93% <0.00%> (ø)
aiohttp/resolver.py 61.70% <0.00%> (ø)
aiohttp/connector.py 93.92% <0.00%> (ø)
aiohttp/multipart.py 96.12% <0.00%> (ø)
aiohttp/test_utils.py 99.06% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d969116...7baf1ee. Read the comment docs.

@asvetlov asvetlov merged commit 254d0e7 into master Nov 12, 2021
@asvetlov asvetlov deleted the clarify-timeouts-behavior branch November 12, 2021 10:59
@patchback
Copy link
Contributor

patchback bot commented Nov 12, 2021 •
edited
Loading

Backport to 3.8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.8/254d0e7d7242e5ffe927501f3ee1370b354b0a96/pr-6274

Backported as #6303

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 12, 2021
@asvetlov
Clarify tiny timeouts behavior and how it can affect performance (#6274)
b1507a1 
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
(cherry picked from commit 254d0e7)
@patchback patchback bot mentioned this pull request Nov 12, 2021
Merged
@patchback
Copy link
Contributor

patchback bot commented Nov 12, 2021 •
edited
Loading

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/254d0e7d7242e5ffe927501f3ee1370b354b0a96/pr-6274

Backported as #6304

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 12, 2021
@asvetlov
Clarify tiny timeouts behavior and how it can affect performance (#6274)
61b503d 
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
(cherry picked from commit 254d0e7)
@patchback patchback bot mentioned this pull request Nov 12, 2021
Merged
asvetlov added a commit that referenced this pull request Nov 12, 2021
@patchback @asvetlov
Clarify tiny timeouts behavior and how it can affect performance (#6274…
065c15b 
…) (#6303)

Co-authored-by: Sviatoslav Sydorenko <[email protected]>
(cherry picked from commit 254d0e7)

Co-authored-by: Andrew Svetlov <[email protected]>
asvetlov added a commit that referenced this pull request Nov 12, 2021
@patchback @asvetlov
Clarify tiny timeouts behavior and how it can affect performance (#6274…
ba8a78b 
…) (#6304)

Co-authored-by: Sviatoslav Sydorenko <[email protected]>
(cherry picked from commit 254d0e7)

Co-authored-by: Andrew Svetlov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz left review comments

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asvetlov @webknjaz