Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot auto-merge #5932

Merged
merged 2 commits into from
Aug 6, 2021
Merged

Dependabot auto-merge #5932

merged 2 commits into from
Aug 6, 2021

Conversation

Dreamsorcerer
Copy link
Member

All remaining PRs on aiohttp-jinja2 auto-merged successfully, so looks like this is the solution.

@Dreamsorcerer Dreamsorcerer requested a review from webknjaz August 6, 2021 19:22
@Dreamsorcerer Dreamsorcerer requested a review from asvetlov as a code owner August 6, 2021 19:23
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 6, 2021
@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #5932 (279f9a2) into master (a341986) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5932   +/-   ##
=======================================
  Coverage   96.75%   96.75%           
=======================================
  Files          44       44           
  Lines        9852     9852           
  Branches     1591     1591           
=======================================
  Hits         9532     9532           
  Misses        182      182           
  Partials      138      138           
Flag Coverage Δ
unit 96.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a341986...279f9a2. Read the comment docs.

@Dreamsorcerer Dreamsorcerer merged commit 3a479d3 into master Aug 6, 2021
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-3 branch August 6, 2021 20:34
@patchback
Copy link
Contributor

patchback bot commented Aug 6, 2021

Backport to 3.8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.8/3a479d39c8012b842f8f1201e288252b0c9c843e/pr-5932

Backported as #5933

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 6, 2021
(cherry picked from commit 3a479d3)
Dreamsorcerer added a commit that referenced this pull request Aug 6, 2021
(cherry picked from commit 3a479d3)

Co-authored-by: Sam Bull <[email protected]>
jobs:
dependabot:
runs-on: ubuntu-latest
if: ${{ github.actor == 'dependabot[bot]' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking, if-clauses do not need interpolation syntax and should only contain expressions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@webknjaz
Copy link
Member

webknjaz commented Oct 7, 2021

@Dreamsorcerer this patch merges the PRs with the GH-provided token. As a result, merge commits don't produce updates and the CI doesn't run after the merge.
The consequence is that this means that the CI also doesn't upload the coverage report to Codecov. Meaning that Codecov shows a drop in coverage on each of such merges: https://app.codecov.io/gh/aio-libs/aiohttp/branch/master/commits?page=1.

@Dreamsorcerer
Copy link
Member Author

@Dreamsorcerer
Copy link
Member Author

Although I'm curious that those merges seem to have a pre-commit status check still run against them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants