-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependabot auto-merge #5932
Dependabot auto-merge #5932
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5932 +/- ##
=======================================
Coverage 96.75% 96.75%
=======================================
Files 44 44
Lines 9852 9852
Branches 1591 1591
=======================================
Hits 9532 9532
Misses 182 182
Partials 138 138
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Backport to 3.8: 💚 backport PR created✅ Backport PR branch: Backported as #5933 🤖 @patchback |
(cherry picked from commit 3a479d3)
(cherry picked from commit 3a479d3) Co-authored-by: Sam Bull <[email protected]>
jobs: | ||
dependabot: | ||
runs-on: ubuntu-latest | ||
if: ${{ github.actor == 'dependabot[bot]' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strictly speaking, if-clauses do not need interpolation syntax and should only contain expressions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tell that to Microsoft. :P
That's a verbatim copy/paste from the docs.
https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/automating-dependabot-with-github-actions#enable-auto-merge-on-a-pull-request
@Dreamsorcerer this patch merges the PRs with the GH-provided token. As a result, merge commits don't produce updates and the CI doesn't run after the merge. |
OK, this suggests using a personal access token: |
Although I'm curious that those merges seem to have a pre-commit status check still run against them. |
All remaining PRs on aiohttp-jinja2 auto-merged successfully, so looks like this is the solution.