Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types for pytest plugin #5585

Merged
merged 4 commits into from
Apr 7, 2021
Merged

Add types for pytest plugin #5585

merged 4 commits into from
Apr 7, 2021

Conversation

Dreamsorcerer
Copy link
Member

This allows people to add an annotation to aiohttp_client when used as a pytest plugin.

Expected usage: def test_foo(aiohttp_client: AiohttpClient):

@Dreamsorcerer Dreamsorcerer requested a review from asvetlov as a code owner April 2, 2021 16:50
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Apr 2, 2021
@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #5585 (f7fb4cb) into master (47b8d63) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5585   +/-   ##
=======================================
  Coverage   97.21%   97.21%           
=======================================
  Files          41       41           
  Lines        8863     8865    +2     
  Branches     1425     1425           
=======================================
+ Hits         8616     8618    +2     
  Misses        130      130           
  Partials      117      117           
Flag Coverage Δ
unit 97.10% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/pytest_plugin.py 97.48% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47b8d63...f7fb4cb. Read the comment docs.

@Dreamsorcerer Dreamsorcerer requested a review from webknjaz April 2, 2021 18:19
@webknjaz
Copy link
Member

webknjaz commented Apr 7, 2021

@Dreamsorcerer would you backport this?

@webknjaz webknjaz merged commit 461bc4b into master Apr 7, 2021
@webknjaz webknjaz deleted the Dreamsorcerer-patch-4 branch April 7, 2021 14:40
commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants