Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to external frozenlist and aiosignal libraries #5293

Merged
merged 6 commits into from
Nov 27, 2020

Conversation

asvetlov
Copy link
Member

Drop local copies

@asvetlov asvetlov requested a review from webknjaz as a code owner November 26, 2020 18:41
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 26, 2020
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 26, 2020

This pull request fixes 1 alert when merging 14959e3 into aa11d78 - view on LGTM.com

fixed alerts:

  • 1 for __eq__ not overridden when adding attributes

@codecov
Copy link

codecov bot commented Nov 27, 2020

Codecov Report

Merging #5293 (278105a) into master (aa11d78) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5293      +/-   ##
==========================================
- Coverage   97.53%   97.52%   -0.01%     
==========================================
  Files          43       41       -2     
  Lines        8803     8740      -63     
  Branches     1414     1406       -8     
==========================================
- Hits         8586     8524      -62     
  Misses        103      103              
+ Partials      114      113       -1     
Flag Coverage Δ
unit 97.41% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/__init__.py 100.00% <ø> (ø)
aiohttp/test_utils.py 99.68% <100.00%> (ø)
aiohttp/tracing.py 100.00% <100.00%> (ø)
aiohttp/web_app.py 97.30% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa11d78...278105a. Read the comment docs.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 27, 2020

This pull request fixes 1 alert when merging 6377364 into aa11d78 - view on LGTM.com

fixed alerts:

  • 1 for __eq__ not overridden when adding attributes

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 27, 2020

This pull request fixes 1 alert when merging 278105a into aa11d78 - view on LGTM.com

fixed alerts:

  • 1 for __eq__ not overridden when adding attributes

@asvetlov asvetlov merged commit 9f659ca into master Nov 27, 2020
@asvetlov asvetlov deleted the drop-frozenlist-aiosignals branch November 27, 2020 09:11
@aio-libs-github-bot
Copy link
Contributor

💔 Backport was not successful

The PR was attempted backported to the following branches:

  • ❌ 3.8: Commit could not be cherrypicked due to conflicts

asvetlov added a commit that referenced this pull request Nov 27, 2020
(cherry picked from commit 9f659ca)

Co-authored-by: Andrew Svetlov <[email protected]>
asvetlov added a commit that referenced this pull request Nov 27, 2020
commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant