-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-commit workflows runs on forks #5258
Labels
Comments
Maybe @webknjaz would be interested since he likes GitHub actions, bots and he is behind sanitizers/octomachinery |
How about adding a conditional on the job level? |
Is it possible? I can try and let you know |
It is. But it's still a runtime check. So the job will show up as skipped. |
I think that's fine. |
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐞 Describe the bug
The pre-commit auto-update workflow runs on forks too, to me it seems unnecessary also because I get an email about a failed job every night, since I do not have secrets set for the bot. In my opinion this workflow should run only on the main repository.
💡 To Reproduce
Just clone the repo and wait for the schedule of to kick in
💡 Expected behavior
The auto-update should not run on forks, it should work only on the main repository.
📋 Logs/tracebacks
Just have a look at my fork, (here)[https://github.com/WisdomPill/aiohttp/actions]
💡 Proposed solutions
Everybody can disable actions on their fork, but it does not seem a viable solution because people will encounter the problem often.
Although github actions does not support to add conditionals on the event, it supports them only in the steps, so an if on every step is what can be done. here
I would be more than happy to contribute to the repo and fix this if the second proposed solution works for you, otherwise let's discuss it and find a more elegant solution to this annoying problem.
The text was updated successfully, but these errors were encountered: