Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update multidict requirement to >= 4.5 #4057

Merged
merged 2 commits into from
Sep 14, 2019
Merged

Update multidict requirement to >= 4.5 #4057

merged 2 commits into from
Sep 14, 2019

Conversation

asvetlov
Copy link
Member

Fix #4053

@asvetlov asvetlov requested a review from webknjaz as a code owner September 14, 2019 19:52
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 14, 2019
@codecov-io
Copy link

codecov-io commented Sep 14, 2019 •
edited
Loading

Codecov Report

Merging #4057 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4057      +/-   ##
==========================================
- Coverage   97.77%   97.73%   -0.05%     
==========================================
  Files          43       43              
  Lines        8777     8777              
  Branches     1377     1377              
==========================================
- Hits         8582     8578       -4     
- Misses         82       85       +3     
- Partials      113      114       +1
Impacted Files Coverage Δ
aiohttp/web_fileresponse.py 96.59% <0%> (-1.14%) ⬇️
aiohttp/connector.py 96.93% <0%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58bfa07...522098a. Read the comment docs.

@asvetlov
Copy link
Member Author

Thanks for the review!

@asvetlov asvetlov merged commit f9c7b0a into master Sep 14, 2019
@asvetlov asvetlov deleted the update-multidict-dep branch September 14, 2019 23:34
asvetlov added a commit that referenced this pull request Sep 14, 2019
@asvetlov
[3.6] Update multidict requirement to >= 4.5 (#4057)
992f7ad 
(cherry picked from commit f9c7b0a)

Co-authored-by: Andrew Svetlov <[email protected]>
asvetlov added a commit that referenced this pull request Sep 15, 2019
@asvetlov
[3.6] Update multidict requirement to >= 4.5 (#4057) (#4060)
f849bf2 
(cherry picked from commit f9c7b0a)

Co-authored-by: Andrew Svetlov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz approved these changes

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: 'ABCMeta' aiohttp==3.6.0, Python 3.6.9
3 participants
@asvetlov @codecov-io @webknjaz