Compat python 3.8

[Hanaasagi]

What do these changes do?

Compat Python 3.8.

• fix import path, because asyncio related exceptions are moved to asyncio.exceptions in 3.8.
• fix make_mocked_coro
• fix the mock patch, because 3.8 adds empty slots to abstract asyncio protocols
• fix some deprecated usage:
  • loop argument is deprecated in asyncio.sleep
  • asyncio.coroutine
  • asyncio.open_connection

Are there changes in behavior for the user?

I think not.

Related issue number

It will resolve #3776

Checklist

• I think the code is well written
• Unit tests for the changes exist
• Documentation reflects the changes
• If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • The format is <Name> <Surname>.
  • Please keep alphabetical order, the file is sorted by names.
• Add a new news fragment into the CHANGES folder
  • name it <issue_id>.<type> for example (588.bugfix)
  • if you don't have an issue_id change it to the pr id after creating the pr
  • ensure type is one of the following:
    • .feature: Signifying a new feature.
    • .bugfix: Signifying a bug fix.
    • .doc: Signifying a documentation improvement.
    • .removal: Signifying a deprecation or removal of public API.
    • .misc: A ticket has been closed, but it is not of interest to users.
  • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

[Hanaasagi]

This pull request is still work in process. Test with Python 3.8.0b4 in my local environment.

run make test

9 failed, 2418 passed, 14 skipped, 3 xfailed, 27 error in 156.87s (0:02:36)

Most errors are due to Python 3.8 adds empty slots to abstract asyncio protocols, please see python/cpython#10889

We can not do something like srv._drain_helper = mock.Mock() directly.

[codecov-io]

Codecov Report

Merging #4056 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4056      +/-   ##
==========================================
- Coverage   97.77%   97.72%   -0.05%     
==========================================
  Files          43       43              
  Lines        8760     8763       +3     
  Branches     1373     1374       +1     
==========================================
- Hits         8565     8564       -1     
- Misses         82       85       +3     
- Partials      113      114       +1

Impacted Files	Coverage Δ
aiohttp/base_protocol.py	96.92% <ø> (ø)	⬆️
aiohttp/streams.py	97.92% <100%> (ø)	⬆️
aiohttp/helpers.py	97.54% <100%> (ø)	⬆️
aiohttp/test_utils.py	99.67% <100%> (ø)	⬆️
aiohttp/web_fileresponse.py	96.59% <0%> (-1.14%)	⬇️
aiohttp/connector.py	96.93% <0%> (-0.33%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc39183...d09d203. Read the comment docs.

[Hanaasagi]

I don't know the difference between https://travis-ci.com/Hanaasagi/aiohttp/builds/127773295 and https://travis-ci.com/aio-libs/aiohttp/builds/127770827.

[asvetlov]

Thanks for the PR.
Please fix my note

[asvetlov]

This change looks irrelevant.

[Hanaasagi]

There are many tests mock the handle_request(not _handle_request), but I could not find where call the handle_request in aiohttp. Only some docstring mentions it.

aiohttp/aiohttp/web_protocol.py

Lines 97 to 99 in dc39183

	RequestHandler handles incoming HTTP request. It reads request line,
	request headers and request payload and calls handle_request() method.
	By default it always returns with 404 response.

Is it an old interface?

[asvetlov]

Heh, it is an excellent demonstration of mocks weakness.

handle_request is self._manager.request_handler I guess.
But our mocked tests didn't fail despite the API was changed.

The fix should be done in a separate PR, this not existing yet pull request is a blocker for your work.

[Hanaasagi]

Due to the asyncio changes, we could not assign a value to handle_request. Actually this block my progress. I need to fix all like

aiohttp/tests/test_web_protocol.py

Line 403 in dc39183

srv.handle_request = handle

change above to

with mock.patch.object(web.RequestHandler, 'handle_request', create=True, new=handle):
    pass

[asvetlov]

Thanks!