Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept non-GET request for starting websocket handshake on server side #3980

Merged
merged 2 commits into from
Aug 15, 2019

Conversation

asvetlov
Copy link
Member

We allow this for client-side starting from aiohttp 3.5

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 15, 2019
@codecov-io
Copy link

Codecov Report

Merging #3980 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3980      +/-   ##
==========================================
- Coverage   97.77%   97.75%   -0.03%     
==========================================
  Files          43       43              
  Lines        8763     8763              
  Branches     1375     1375              
==========================================
- Hits         8568     8566       -2     
- Misses         83       84       +1     
- Partials      112      113       +1
Impacted Files Coverage Δ
aiohttp/web_fileresponse.py 96.59% <0%> (-1.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5a80c8...379ffb2. Read the comment docs.

@asvetlov asvetlov merged commit 8f619a5 into master Aug 15, 2019
@asvetlov asvetlov deleted the relax-ws-handshake-method branch August 15, 2019 16:12
asvetlov added a commit that referenced this pull request Aug 15, 2019
…er side (#3980)

(cherry picked from commit 8f619a5)

Co-authored-by: Andrew Svetlov <[email protected]>
asvetlov added a commit that referenced this pull request Aug 16, 2019
…er side (#3980) (#3982)

(cherry picked from commit 8f619a5)

Co-authored-by: Andrew Svetlov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants