-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Cython usage #3693
Comments
See also: pypa/pip#6144 I think I've actually got it figured out in #3581. The current implementation relies on an undefined So the only thing left to do is to put it into a separate dist. (And it works!) |
manylinux is broken still but #3694 solves almost everything |
I'd keep this open anyway. I'm still thinking of improvements. |
Up to you, the PR will hang for years then. |
The issue is solved by adding explicit |
pip 19+ uses isolated virtual environments to install a package.
It breaks a build, please read #3581 report
The idea is:
.pyx
files are already precompiled into.c
sources..c
are already present in distribution tarball. Binary wheels don't need to compile sources at all.Makefile
before installingaiohttp
library.AIOHTTP_NO_EXTENSIONS=1
env var. Otherwise, a compilation error is raised. It prevents a silent performance degradation if aiohttp installed on Alpine or OS without C compiler toolchain.#3694 addresses points 1-3, it can be backported to aiohttp 3.5.
The 4th bullet is not backward compatible. It should be implemented in a separate PR and land on aiohttp 4.0 only.
The text was updated successfully, but these errors were encountered: