[3.5] Use sanitized URL as Location header in redirects #3614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
@webknjaz Looking at it again, I think this might be seen as breaking for some of the users who expect the location property on an HTTPFound object to be a string if they passed a string (and also I broke a test and made the mistake of not running them locally before opening the PR). Should I fix this in a follow-up PR? |
|
Odd... CI was green. I'm not sure what you mean but PR is welcome and we can go through a review process there :) |
psf-chronographer
bot
added
the
bot:chronographer:provided
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3613 for the 3.5 branch