-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readd aiohttp.{get,post,...} shortcuts #3427
Comments
GitMate.io thinks the contributor most likely able to help you is @asvetlov. Possibly related issues are #1403 ([QUESTION] aiohttp.ClientSession.request('GET') issue), #2224 (aiohttp.TCPConnector()), #469 (how to get the post data), #161 (aiohttp can't send files by POST request correct), and #1593 (Drop aiohttp.get(), aiohttp.options(), aiohttp.head(), aiohttp.post(), aiohttp.put(), aiohttp.patch(), aiohttp.delete(), and aiohttp.ws_connect()). |
I not sure should we resurrect these functions or not. Maybe |
Main problem of those shortcuts is that they became too popular to let users forget about Session thing, which isn't much popular in requests justs because of that. And because of that there around happens questions about cookies, state preserve, performance, keep-alive and others related to the session state. I think, one line with session open isn't higher price to not think about all of this. |
I'm 👎 on this: |
Looks like the decision is to reject the proposal, at least for aiohttp 4.x |
having these shortcuts in the
requests
library is very useful. they feel natural. having them inaiohttp
would be even better. 😄The text was updated successfully, but these errors were encountered: