Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake8 dependency for dev environment #3345

Closed
dbohomiakov opened this issue Oct 15, 2018 · 3 comments
Closed

Fix flake8 dependency for dev environment #3345

dbohomiakov opened this issue Oct 15, 2018 · 3 comments

Comments

@dbohomiakov
Copy link
Contributor

Long story short

There is an inconsistency in the requirements files. In the requirements/ci-wheel.txt explicitly defined pyflakes with version 2.0.0 but flake8 which uses pyflakes as dependency requires version from the range >= 1.5.0, < 1.7.0. The newest version overwrites the required one.

Expected behaviour

Actual behaviour

Steps to reproduce

pip install -r requirements/dev.txt

Your environment

MacOS 10.14, python 3.6.5, aiohttp 3.4.4
both

@aio-libs-bot
Copy link

GitMate.io thinks the contributor most likely able to help you is @asvetlov.

Possibly related issues are #1485 (Fix broken Cookies support), #318 (Make chardet dependency mandatory), #82 (Fix proxy issue), #1973 (Dependency problem when using tox), and #67 (fix header encoding error).

@asvetlov
Copy link
Member

Fixed by #3346

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants