Implement streaming request data generation for ClientRequest

[socketpair]

i.e. possible API (pseudocode, actual API may be completely different):

with web.ClientSession() as session:
    async with session.post('/') as req:
        writestream = req.get_write_stream()
        writestream.write('xxx')
        await writestream.drain()
        writestream.write_eof()
        ...

In my case, I have unknown amount of data that sould be sent in the body of the POST-request (i.e. chunked request). Streaming request/response is available for server-side. But for client-side, streaming requests are not available...Maybe I miss something ?

[fafhrd91]

this is for 2.0 http://aiohttp.readthedocs.io/en/latest/client.html#streaming-uploads
this is for 1.3 http://aiohttp.readthedocs.io/en/stable/client.html#streaming-uploads

[fafhrd91]

I like your idea, I need to think how implementation could look like

[socketpair]

wow. http://aiohttp.readthedocs.io/en/stable/client_reference.html#aiohttp.ClientSession.request said that:

So, it does not mention that this can be stream, actually...
Also,

Is writer.write() really coroutine ?

[fafhrd91]

it is new subsystem in 2.0, there is payload registry, it is not documented yet.

here is payload implementation for StreamReader https://github.com/aio-libs/aiohttp/blob/master/aiohttp/payload.py#L263

technically writer.write() is not a coroutine, but I would use it as coroutine because it does drain()
writer is an instance if PayloadWriter class https://github.com/aio-libs/aiohttp/blob/master/aiohttp/http_writer.py#L130

[fafhrd91]

with payloads you can do fancy stuff like this:

https://github.com/aio-libs/aiohttp/blob/master/tests/test_web_functional.py#L1526

[asvetlov]

Superseded by #2802

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new