Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

body for HTTP GET request #141

Closed
asvetlov opened this issue Aug 28, 2014 · 4 comments
Closed

body for HTTP GET request #141

asvetlov opened this issue Aug 28, 2014 · 4 comments
Labels

Comments

@asvetlov
Copy link
Member

When aiohttp.request gets GET method with specified data that merges data to url along with params.

I think that's wrong. HTTP protocol standard (http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html) says nothing about presence/absence body for GET methods.

Moreover elasticsearch uses GETs with body for some REST API methods: see http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/docs-multi-get.html and http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/search-multi-search.html#search-multi-search

I guess to always process data as for POST request if specified.

@kxepal
Copy link
Member

kxepal commented Aug 28, 2014

few more interesting discussions:
http://lists.w3.org/Archives/Public/ietf-http-wg/2002JulSep/0031.html
http://lists.w3.org/Archives/Public/ietf-http-wg/2007JanMar/0076.html

TL;DR technically, it's ok to send body with GET/DELETE requests. Semantically - it's not. In real world only few uses such "feature".

@fafhrd91
Copy link
Member

+1

let's unify 'data' processing for all type of requests

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants