-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mktar_from_directory
util
#602
Comments
Looks like a great idea. |
@asvetlov does it mean that existing |
Sorry, I cannot find |
Sorry, mb - mktar_from_dockerfile |
I think a separate function is needed. |
the most simple implementation would be to send the entire directory/context - ideally it would be able to filter according to any |
Maybe use docker-py implementation with |
sounds like a plan, but im guessing we would want to avoid a dependency, so i guess it would be a matter of cribbing it |
they also cribbed it from moby |
I'd also suggest refactoring |
Long story short
I have used aiodocker in a couple of projects, the one thing i find myself implementing is a
mktar_from_directory
function (or similar) to enable building an image with artefactsmy implementaion/s are very similar to the existing
mktar_from_directory
, im wondering if it would be helpful to PR this additionHow to reproduce
try to build an image that has artefacts
The text was updated successfully, but these errors were encountered: