PseudoPotentialFamily: override remove_nodes and clear
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods need to be overridden, such that after they have called the implementation of the `Group` base class, the internal `_pseudos` class attribute can be updated accordingly. For `clear` this is easy as it is simply set to `None`, but for `remove_nodes` special care needs to be taken. It needs to account for the fact that a single node or an iterable of nodes can be passed as an argument, and that the base class implementation will not raise if any of the nodes is not actually contained in the group. So instead of doing the straight forward thing of removing the nodes from `_pseudos` based on the elements, we remove them based on the pk, which guarantees we are removing the correct nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27
These methods need to be overridden, such that after they have called
the implementation of the
Groupbase class, the internal_pseudosclass attribute can be updated accordingly. For
clearthis is easy asit is simply set to
None, but forremove_nodesspecial care needs tobe taken. It needs to account for the fact that a single node or an
iterable of nodes can be passed as an argument, and that the base class
implementation will not raise if any of the nodes is not actually
contained in the group. So instead of doing the straight forward thing
of removing the nodes from
_pseudosbased on the elements, we removethem based on the pk, which guarantees we are removing the correct nodes.