Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Test with RabbitMQ 4.0.x #6649

Merged
merged 5 commits into from
Dec 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .docker/aiida-core-base/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ ENV SYSTEM_USER="${SYSTEM_USER}"

# Install all OS dependencies for notebook server that starts but lacks all
# features (e.g., download as all possible file formats)
ENV DEBIAN_FRONTEND noninteractive
ENV DEBIAN_FRONTEND=noninteractive
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sneaked in this unrelated change to get rid of deprecation warnings seen on Github

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I like if we see tiny things (hard to say how tiny is tiny, for me it is like one line change not related to the code logic and sure it is 100% correct) like this we clean it up.

RUN apt-get update --yes && \
# - apt-get upgrade is run to patch known vulnerabilities in apt-get packages as
# the ubuntu base image is rebuilt too seldom sometimes (less than once a month)
Expand Down Expand Up @@ -145,7 +145,7 @@ RUN set -x && \
# Add ~/.local/bin to PATH where the dependencies get installed via pip
# This require the package installed with `--user` flag in pip, which we set as default.
ENV PATH=${PATH}:/home/${SYSTEM_USER}/.local/bin
ENV PIP_USER 1
ENV PIP_USER=1

# Switch to root to install AiiDA and set AiiDA as service
# Install AiiDA from source code
Expand Down
15 changes: 9 additions & 6 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,15 @@ jobs:
uses: ./.github/actions/install-aiida-core
with:
python-version: '3.11'
from-lock: 'true'

- name: Setup environment
run: .github/workflows/setup.sh
# NOTE: virtual env in .venv created by uv in previous step
run: source .venv/bin/activate && .github/workflows/setup.sh

- name: Run tests
id: tests
run: .github/workflows/tests_nightly.sh
run: source .venv/bin/activate && .github/workflows/tests_nightly.sh

- name: Slack notification
# Always run this step (otherwise it would be skipped if any of the previous steps fail) but only if the
Expand Down Expand Up @@ -101,7 +103,7 @@ jobs:
matrix:
# Currently supported RMQ versions per:
# https://www.rabbitmq.com/docs/which-erlang#compatibility-matrix
rabbitmq-version: ['3.11', '3.12', '3.13']
rabbitmq-version: ['3.11', '3.12', '3.13', '4.0']

services:
rabbitmq:
Expand All @@ -118,18 +120,19 @@ jobs:
uses: ./.github/actions/install-aiida-core
with:
python-version: '3.11'
from-lock: 'true'

- name: Setup SSH on localhost
run: .github/workflows/setup_ssh.sh
run: source .venv/bin/activate && .github/workflows/setup_ssh.sh

- name: Suppress RabbitMQ version warning
run: verdi config set warnings.rabbitmq_version False
run: uv run verdi config set warnings.rabbitmq_version False

- name: Run tests
id: tests
env:
AIIDA_WARN_v3: 0
run: pytest -s --db-backend sqlite -m 'requires_rmq' tests/
run: uv run pytest -s --db-backend sqlite -m 'requires_rmq' tests/

- name: Slack notification
# Always run this step (otherwise it would be skipped if any of the previous steps fail) but only if the
Expand Down
Loading