CI: Test with RabbitMQ 4.0.x #6649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6649 +/- ##
==========================================
+ Coverage 77.51% 77.93% +0.43%
==========================================
Files 560 563 +3
Lines 41444 41662 +218
==========================================
+ Hits 32120 32464 +344
+ Misses 9324 9198 -126 ☔ View full report in Codecov by Sentry. |
danielhollas
commented
Dec 2, 2024
| @@ -24,7 +24,7 @@ ENV SYSTEM_USER="${SYSTEM_USER}" | |||
|
|
|||
| # Install all OS dependencies for notebook server that starts but lacks all | |||
| # features (e.g., download as all possible file formats) | |||
| ENV DEBIAN_FRONTEND noninteractive | |||
| ENV DEBIAN_FRONTEND=noninteractive | |||
There was a problem hiding this comment.
I sneaked in this unrelated change to get rid of deprecation warnings seen on Github
There was a problem hiding this comment.
Actually I like if we see tiny things (hard to say how tiny is tiny, for me it is like one line change not related to the code logic and sure it is 100% correct) like this we clean it up.
unkcpz
approved these changes
Dec 5, 2024
|
Whoops, RMQ and nightly tests are failing due the uv lockfile PR. I'll fix that. |
unkcpz
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if RMQ 4.0 passes the tests.
https://aiida.discourse.group/t/supported-rabbitmq-versions/392/11?u=danielhollas