Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes made during iteration over result of iterall are not persisted #6133

Closed
sphuber opened this issue Sep 22, 2023 · 0 comments · Fixed by #6134
Closed

Changes made during iteration over result of iterall are not persisted #6133

sphuber opened this issue Sep 22, 2023 · 0 comments · Fixed by #6134
Assignees
@sphuber
Labels
priority/critical-blocking must be resolved before next release topic/query-builder topic/storage type/bug

Comments

@sphuber
Copy link
Contributor

sphuber commented Sep 22, 2023

The QueryBuilder.iterall for the PsqlDosBackend should open a transaction and so commit all changes after the iteration finishes, but this is not the case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sphuber sphuber

Labels
priority/critical-blocking must be resolved before next release topic/query-builder topic/storage type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PsqlDosBackend: Fix changes not persisted after iterall and iterdict sphuber/aiida-core
1 participant
@sphuber