Skip to content

Commit

Permalink
ignore warnings and leave comment on what needs to be improved
Browse files Browse the repository at this point in the history
  • Loading branch information
unkcpz committed Oct 21, 2023
1 parent e64cb3d commit cc4dba1
Show file tree
Hide file tree
Showing 4 changed files with 28 additions and 2 deletions.
25 changes: 25 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,29 @@ filterwarnings = [
# E _warn("subprocess %s is still running" % self.pid,
# E ResourceWarning: subprocess 382685 is still running
'ignore:Exception ignored in:pytest.PytestUnraisableExceptionWarning:_pytest',
# TODO: This comes from a transitive dependency of optimade_client
# Remove this when this issue is addressed:
# https://github.com/CasperWA/ipywidgets-extended/issues/85
'ignore::DeprecationWarning:ipywidgets_extended',
# TODO: StructureManagerWidget pass arguments by kwargs to StructureDataViewer and will be deprecated.
# E DeprecationWarning: Passing unrecognized arguments to super(StructureManagerWidget).__init__(configuration_tabs=['Cell', 'Selection', 'Appearance', 'Download']).
# E object.__init__() takes exactly one argument (the instance to initialize)
# E This is deprecated in traitlets 4.2.This error will be raised in a future release of traitlets.
'ignore::DeprecationWarning:ipywidgets',
'ignore::DeprecationWarning:ase.atoms',
# TODO: bandsplot_widget has an issue in schema validation
# > result._update_view()
#
# tests/test_plugins_bands.py:12:
# _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
# src/aiidalab_qe/plugins/bands/result.py:40: in _update_view
# _bands_plot_view = BandsPlotWidget(
# ../../.local/lib/python3.9/site-packages/widget_bandsplot/bandsplot.py:112: in __init__
# validate(instance=i, schema=BANDS_SCHEMA)
# /opt/conda/lib/python3.9/site-packages/jsonschema/validators.py:928: in validate
# cls = validator_for(schema)
'ignore::DeprecationWarning:jsonschema',
# TODO: use uuid instead of node object in WorkChainViewer.
# Otherwise, the `Instance '<DbNode at 0x7f2f1bd885b0>' is not persistent within this Session` exception is raised.
'ignore::pytest.PytestUnhandledThreadExceptionWarning:_pytest',
]
1 change: 1 addition & 0 deletions src/aiidalab_qe/app/configuration/advanced.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ class AdvancedSettings(Panel):

# protocol interface
protocol = tl.Unicode(allow_none=True)
# TODO: (unckpz) the DbNode persistence issue will be raised if using AiiDA Node as the trait.
input_structure = tl.Instance(orm.StructureData, allow_none=True)
spin_type = tl.Unicode()
electronic_type = tl.Unicode()
Expand Down
2 changes: 1 addition & 1 deletion src/aiidalab_qe/app/result/workchain_viewer.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,11 +111,11 @@ def toggle_camera():
**kwargs,
)
self._process_monitor = ProcessMonitor(
process=self.node,
callbacks=[
self._update_view,
],
)
self._process_monitor.value = self.node.uuid

def _update_view(self):
with self.hold_trait_notifications():
Expand Down
2 changes: 1 addition & 1 deletion tests/test_result.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,5 +76,5 @@ def test_summary_view(generate_qeapp_workchain):
"Initial Magnetic Moments": "",
}
for key, value in parameters.items():
td = parsed.find("td", text=key).find_next_sibling("td")
td = parsed.find("td", string=key).find_next_sibling("td")
assert td.text == value

0 comments on commit cc4dba1

Please sign in to comment.