-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipenv install fails #68
Comments
@oindrillac why are you forcing |
By not specifying the versions for |
@MichaelClifford hatesonar with a scikit-learn > 0.20.3 was giving this error The problem above is not only with installing scikit-learn==0.20.3. Noticed the same when I tried
Doesnt the elyra v6 image support 3.8? The repo is on version python 3.6, and hence I've been trying this on the mailing-list image. |
@MichaelClifford on a version greater than 0.20.3
|
since the |
@oindrillac From the error message, it looks like the issue is not hatesonar or sklearn, but rather black. What happens when you explicitly mention black version in the pipfile like this:
The above works fine for me on operate-first JH, on the |
@chauhankaranraj thanks for the tip
however, i think the scikit-learn version is still throws a conflict when
getting the version mismatch issue
and I am not sure how we can overcome this other than not tracking the scikit-learn pinned dependency in the Pipfile. |
@pacospace do you think we could mitigate this issue by using "overlays" and having notebook specific dependencies? If so, we should look into using those here. This is a good first use case for a Elyra/KFpipeline that actually requires unique runtime images for individual notebooks. How does the aicoe-ci/build-check handle repo's with out a global Pipfile? |
Thanks @MichaelClifford, I agree could be a very nice use case. The tutorial we have shows how the repo will look like: https://github.com/thoth-station/elyra-aidevsecops-tutorial Basically each notebook will have its own kernel and So steps are:
Then when you open a release the aicoe-ci pipeline will do the magic and each overlays will have an image on your registry depending on the name you specify in the .aicoe.yaml. Then your images are ready to be used in the Elyra Pipeline. |
Describe the bug
Pipenv install of
hatesonar
andscikit-learn==0.20.3
fails.To Reproduce
Trying out similar workflow from #51 (comment) fails.
mailing-list-analysis-toolkit
image@tumido any recommendations?
cc: @cdolfi
related to : #54
The text was updated successfully, but these errors were encountered: