refactor: Improve actions samples random selection #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the action samples random selection by ensuring a bigger variety of actions are represented in the selection (as long as there is enough place, at least one example per action should be added)
odilitime
approved these changes
Dec 2, 2024
|
Yes, it has improved :) But relying on randomness doesn't seem ideal to me. If we integrate the actions, we should ensure they are reliably triggerable rather than dependent on randomness. |
shakkernerd
changed the title
shakkernerd
previously approved these changes
Dec 3, 2024
shakkernerd
approved these changes
Dec 3, 2024
dsldsl
pushed a commit
to dsldsl/eliza
that referenced
this pull request
Dec 7, 2024
refactor: Improve actions samples random selection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
#798
Risks
low, but it makes LLM sometimes not understand that they can trigger an action because they don't have any example corresponding
Background
What does this PR do?
This PR changes the algorithm that selects the actions examples that are sent to the model
What kind of change is this?
Improvements
Documentation changes needed?
My changes do not require a change to the project documentation.
Testing
not really testable except if you do console logs but the difference is there.