Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: memory similarity log & new knowledge ingestion #616

Conversation

yoniebans
Copy link
Contributor

Relates to:

#615
#614

Risks

Low:

  • Change a break; to continue;
  • Use the correct object in a logging statement
  • Update .gitignore so the generatedImages folder doesn't get added to source control

Background

What does this PR do?

A couple of small changes:

  1. Fix the issue where new knowledge entries in character profile don't get included in agents memory db.
  2. Fix for memory fragment similarity score logging.
  3. Updated gitignore in /agent to ignore generated images

What kind of change is this?

Bug fixes (non-breaking change which fixes an issue)

Why are we doing this? Any context or related work?

To make changes to core knowledge work and log memory related search metrics correctly.

Documentation changes needed?

My changes do not require a change to the project documentation.

Testing

Where should a reviewer start?

Screenshots and replication steps for 2 bugs described in the linked issues.

Detailed testing steps

See linked issues

Discord username

yoniebans

…t the message similarity which is undefined. think memory similarity is what we're looking for in the .map function
@yoniebans yoniebans changed the title Bug/memory similarity log new knowledge ingestion fix: memory similarity log new knowledge ingestion Nov 26, 2024
@yoniebans yoniebans changed the title fix: memory similarity log new knowledge ingestion fix: memory similarity log & new knowledge ingestion Nov 26, 2024
@bmgalego
Copy link
Contributor

looks good

@lalalune lalalune merged commit 3b3800e into elizaOS:main Nov 26, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants