-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement coinbase trading #608
Merged
jkbrooks
merged 26 commits into
elizaOS:main
from
monilpat:realitySpiral/coinbaseTrading
Nov 28, 2024
Merged
feat: implement coinbase trading #608
jkbrooks
merged 26 commits into
elizaOS:main
from
monilpat:realitySpiral/coinbaseTrading
Nov 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have conflicts
|
Yup aware and resolving them :) |
…nilpat/eliza into realitySpiral/coinbaseTrading
…nilpat/eliza into realitySpiral/coinbaseTrading
…nilpat/eliza into realitySpiral/coinbaseTrading
snobbee
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! great work!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
Coinbase support
Risks
package.json
may cause version conflicts.Background
What does this PR do?
This PR implements the Coinbase trading functionality using the Coinbase SDK. It adds the ability to:
What kind of change is this?
Documentation changes needed?
Testing
Where should a reviewer start?
Begin with the following files:
packages/plugin-coinbase/src/plugins/trade.ts
: Contains the trading logic and integration.packages/plugin-coinbase/src/utils.ts
: Handles wallet initialization.Detailed testing steps:
Wallet Initialization:
initializeWallet
function to create a new wallet with the Coinbase API keys.Execute a Trade:
executeTradeAction
in thetradePlugin
.Verify Trade Logging:
trades.csv
file for accurate logging of the executed trade.Negative Testing:
Screenshots (if applicable):
Before:
N/A (New feature).
After:
https://drive.google.com/file/d/1xeUW9sbQ74DinzFrXjqps7o2wqFWRSNv/view?usp=sharing
Successful Trade:
Error Handling:
Deploy Notes:
Database Changes:
None.
Deployment Instructions:
Add the following environment variables to
.env
:Run
pnpm install
to update dependencies.Test all features in a staging environment before deploying to production.