fix: Fix linter issues #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monilpat
reviewed
Nov 18, 2024
packages/core/src/parsing.ts
Outdated
| @@ -65,7 +65,7 @@ export function parseJsonArrayFromText(text: string) { | |||
| if (jsonBlockMatch) { | |||
| try { | |||
| jsonData = JSON.parse(jsonBlockMatch[1]); | |||
| } catch (e) { | |||
| } catch { | |||
There was a problem hiding this comment.
Can we log the error with console.error instead of removing this?
monilpat
reviewed
Nov 18, 2024
packages/core/src/parsing.ts
Outdated
| @@ -118,7 +118,7 @@ export function parseJSONObjectFromText( | |||
| if (objectMatch) { | |||
| try { | |||
| jsonData = JSON.parse(objectMatch[0]); | |||
| } catch (e) { | |||
| } catch { | |||
There was a problem hiding this comment.
same here and everywhere else
|
LGTM outside of adding console.error for the catch statements |
|
@monilpat @martincik We have a build error, can we address before merge? |
martincik
force-pushed
the
fix/fix-linter-issues
branch
from
7cc6f58 to
d49611b
Compare
|
@jkbrooks Build and lint fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
No specific issue linked - appears to be a code quality improvement PR
Risks
Low - Changes are purely related to code style and import organization with no functional changes.
Background
What does this PR do?
This PR addresses linting issues in the codebase by:
What kind of change is this?
Improvements (misc. changes to existing features)
Documentation changes needed?
My changes do not require a change to the project documentation.
Testing
Where should a reviewer start?
Review the changes in the following files:
Detailed testing steps
No, automated tests are fine. These changes are purely syntactic and don't affect functionality.
The changes include:
Since these are linter-driven changes, existing tests should cover functionality verification.