add node version check #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
#269
Risks
Low
Background
Currently the build processes continues even if the node version is less than 23 or not, which can confuse some developers trying to build, keeping in mind the warning thrown by the default node env is very minimal.
What does this PR do?
This PR aims to explicitly checks for node version and throws error during the build pro
What kind of change is this?
Improvement to exisitng build flow
Documentation changes needed?
I have updated the documentation accordingly to match the required node version.
Testing
Where should a reviewer start?
Just run the
pnpm buildcmd with node version less than23and greater than23