Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Starknet plugin #287

Merged
merged 7 commits into from
Nov 15, 2024
Merged

feat: Starknet plugin #287

merged 7 commits into from
Nov 15, 2024

Conversation

ponderingdemocritus
Copy link
Contributor

@ponderingdemocritus ponderingdemocritus commented Nov 13, 2024 •
edited
Loading

  • PR turned into type and import cleanup. Conflicts were happening between bundled and non-bundled types. This is now resolved
  • Implements scaffold for Starknet plugin that allows swapping.
  • adds pr title workflow - for sanity and cleanliness

After building and tests, lets merge to keep head clean, then will keep iterating on SN plugin

@ponderingdemocritus ponderingdemocritus marked this pull request as ready for review November 15, 2024 23:12
@lalalune lalalune merged commit 8fe9cb5 into main Nov 15, 2024
3 checks passed
@lalalune lalalune deleted the starknet-plugin branch November 15, 2024 23:23
@sirkitree
Copy link
Collaborator

This seems to have removed all tests. Is there a plan for adding them back? If we want to get into a reliable release path we should have proper test coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ponderingdemocritus @sirkitree @lalalune