Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build.sh crash #379

Closed
denizekiz opened this issue Nov 17, 2024 · 3 comments
Closed

build.sh crash #379

denizekiz opened this issue Nov 17, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@denizekiz
Copy link
Contributor

Describe the bug

build.sh doesn't work in Windows due to usage of "cut" for node version check. We need a cross-platform solution for checking node.js, or just remove node.js version check.
To Reproduce

build.sh
@denizekiz denizekiz added the bug Something isn't working label Nov 17, 2024
@whonion
Copy link
Contributor

whonion commented Nov 18, 2024

Note for Windows Users: WSL is required

@sirkitree
Copy link
Collaborator

i just ran this in PS fine

hash: a2e0954 from main
no. just main branch, node v23.1.0, pnpm clean, pnpm install, pnpm build, pnpm start --character=(file)

@denizekiz
Copy link
Contributor Author

WSL 2 installing instructions added for windows users to readme.md
#419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sirkitree @denizekiz @whonion