Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global variable access? #787

Closed
LongTengDao opened this issue Aug 9, 2019 · 0 comments · Fixed by #788
Closed

global variable access? #787

LongTengDao opened this issue Aug 9, 2019 · 0 comments · Fixed by #788

Comments

@LongTengDao
Copy link
Contributor

LongTengDao commented Aug 9, 2019 •
edited
Loading

gm/lib/compare.js

Line 91 in e715cbd

err = null;

gm/lib/compare.js

Line 106 in e715cbd

err = new Error('Unable to parse output.\nGot ' + stdout);

gm/lib/compare.js

Line 107 in e715cbd

return cb(err);

It's a feature or leak?

I see these happened from 5f5c774#diff-4188dbce06d21f3a05e4e5edb8aa4889

@rwky Would you help to review my fix PR #788 ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clear up the ruins LongTengDao-fork-A/gm
1 participant
@LongTengDao