Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mypy support #25

Closed
4 tasks done
ahawker opened this issue Jun 26, 2017 · 1 comment
Closed
4 tasks done

Add mypy support #25

ahawker opened this issue Jun 26, 2017 · 1 comment
Assignees
@ahawker
Labels
enhancement quality

Comments

@ahawker
Copy link
Owner

ahawker commented Jun 26, 2017 •
edited
Loading

This package was written with type hints (PEP484) so it should perform some static analysis checks on build.

  • Add make target for invoking checks
  • Add tox target?
  • Add pytest support?
  • Add TravisCI support
@ahawker
Copy link
Owner Author

ahawker commented Jun 26, 2017

Ran into python/mypy#1775 while working on this tonight.

Thought is to add some type hint aliases in hints.py or top-level in ulid.py to address the collision between model representation properties and built-in type names.

@ahawker ahawker mentioned this issue Jun 26, 2017
Merged
@ghost ghost assigned ahawker Jun 26, 2017
@ghost ghost added in progress and removed ready labels Jun 26, 2017
@ghost ghost removed the in progress label Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahawker ahawker

Labels
enhancement quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ahawker