From 390fd2d0a26538a75bc5d7caaf1dd713a04b070e Mon Sep 17 00:00:00 2001 From: Simon Mavi Stewart Date: Tue, 3 Oct 2023 11:13:42 +0100 Subject: [PATCH] [dotnet] Break out the individual dotnet "small" tests --- .skipped-tests | 2 +- dotnet/private/dotnet_nunit_test_suite.bzl | 2 ++ dotnet/test/support/Events/BUILD.bazel | 4 ++-- dotnet/test/support/Extensions/BUILD.bazel | 4 ++-- dotnet/test/support/UI/BUILD.bazel | 4 ++-- 5 files changed, 9 insertions(+), 7 deletions(-) diff --git a/.skipped-tests b/.skipped-tests index 3d5a74fb9ce91..fa2bdbbec7cb7 100644 --- a/.skipped-tests +++ b/.skipped-tests @@ -7,7 +7,7 @@ -//dotnet/test/common:TakesScreenshotTest-firefox -//dotnet/test/common:VirtualAuthn/VirtualAuthenticatorTest-chrome -//dotnet/test/support/UI:SelectBrowserTests-firefox --//dotnet/test/support/UI:SmallTests +-//dotnet/test/support/UI:SelectTests -//java/test/org/openqa/selenium:FormHandlingTest-chrome -//java/test/org/openqa/selenium/bidi:BiDiSessionTest-remote -//java/test/org/openqa/selenium/bidi:BiDiTest-remote diff --git a/dotnet/private/dotnet_nunit_test_suite.bzl b/dotnet/private/dotnet_nunit_test_suite.bzl index 4f81f32b00969..1116037eb21e0 100644 --- a/dotnet/private/dotnet_nunit_test_suite.bzl +++ b/dotnet/private/dotnet_nunit_test_suite.bzl @@ -139,6 +139,7 @@ def dotnet_nunit_test_suite( target_frameworks = target_frameworks, data = data, tags = tags, + size = size, **kwargs ) tests.append(test_name) @@ -160,6 +161,7 @@ def dotnet_nunit_test_suite( args = _BROWSERS[browser]["args"] + _HEADLESS_ARGS, data = data + _BROWSERS[browser]["data"], tags = tags + [browser] + COMMON_TAGS + _BROWSERS[browser]["tags"], + size = size, **kwargs ) tests.append(browser_test_name) diff --git a/dotnet/test/support/Events/BUILD.bazel b/dotnet/test/support/Events/BUILD.bazel index a5f7c2f7d60b0..415162982d651 100644 --- a/dotnet/test/support/Events/BUILD.bazel +++ b/dotnet/test/support/Events/BUILD.bazel @@ -1,10 +1,10 @@ -load("//dotnet:defs.bzl", "dotnet_nunit_test_suite", "framework", "nunit_test") +load("//dotnet:defs.bzl", "dotnet_nunit_test_suite", "framework") SMALL_TESTS = [ "EventFiringWebDriverTest.cs", ] -nunit_test( +dotnet_nunit_test_suite( name = "SmallTests", size = "small", srcs = SMALL_TESTS, diff --git a/dotnet/test/support/Extensions/BUILD.bazel b/dotnet/test/support/Extensions/BUILD.bazel index 5bd63a4ab7583..14ad729c0bcd6 100644 --- a/dotnet/test/support/Extensions/BUILD.bazel +++ b/dotnet/test/support/Extensions/BUILD.bazel @@ -1,6 +1,6 @@ -load("//dotnet:defs.bzl", "framework", "nunit_test") +load("//dotnet:defs.bzl", "dotnet_nunit_test_suite", "framework") -nunit_test( +dotnet_nunit_test_suite( name = "SmallTests", size = "small", srcs = glob(["*.cs"]), diff --git a/dotnet/test/support/UI/BUILD.bazel b/dotnet/test/support/UI/BUILD.bazel index 15bce7010c76c..e3af6774acc85 100644 --- a/dotnet/test/support/UI/BUILD.bazel +++ b/dotnet/test/support/UI/BUILD.bazel @@ -1,4 +1,4 @@ -load("//dotnet:defs.bzl", "dotnet_nunit_test_suite", "framework", "nunit_test") +load("//dotnet:defs.bzl", "dotnet_nunit_test_suite", "framework") SMALL_TESTS = [ "DefaultWaitTest.cs", @@ -9,7 +9,7 @@ SMALL_TESTS = [ "WebDriverWaitTest.cs", ] -nunit_test( +dotnet_nunit_test_suite( name = "SmallTests", size = "small", srcs = SMALL_TESTS,