Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depth index should not be called DEPT #205

Open
kwinkunks opened this issue Feb 18, 2022 · 5 comments
Open

Depth index should not be called DEPT #205

kwinkunks opened this issue Feb 18, 2022 · 5 comments

Comments

@kwinkunks
Copy link
Member

DEPT is a LAS thing, and could sometimes be TIME or DEPTH (as well as DEPT... yes, it's gross). At least, those are the 3 options in the standard. I suppose a person could come up with other things (MD, TVDSS, etc).

We should probably regularize it to DEPTH or TIME, so at least it's somewhat predictable. depth or time might be even more convenient, but a person might possibly suppose that it's uppercase, based on the standard.

Calling it a bug, because it's a break from the welly philosophy of being natural and 'geological', not just mirroring the LAS standard (that's what lasio is for).

@ThomasMGeo
Copy link
Contributor

Does it make sense to make it Depth_ft or Depth_m? Might be too weird.

@kwinkunks
Copy link
Member Author

I do like the idea of bringing units closer to everything, but there is a basis_units attribute, so I think it's okay to maintain that.

@ThomasMGeo
Copy link
Contributor

💯 ! Sounds good, that makes sense.

@patrick-reinhard
Copy link
Collaborator

If we go ahead with this, would we like to support a way that you can still export with the original index mnemonic (e.g. DEPT) ?

@kinverarity1
Copy link
Contributor

Agreed - in lasio it's properly "index" i.e. first curve is LASFile.index, but I don't think that's a very natural term to a geologist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants