From 5a076d0204447e11820f064127ca4d24b0e79611 Mon Sep 17 00:00:00 2001
From: Melantha Wang <wang.melantha@gmail.com>
Date: Wed, 2 Mar 2022 16:34:53 +1100
Subject: [PATCH] Update claim_majRev_size to work with > 3 major revisions

---
 SPLICE/NEWS.md                         | 10 ++++++++++
 SPLICE/R/features_09_major_revisions.R |  4 ++--
 2 files changed, 12 insertions(+), 2 deletions(-)
 create mode 100644 SPLICE/NEWS.md

diff --git a/SPLICE/NEWS.md b/SPLICE/NEWS.md
new file mode 100644
index 0000000..72cd903
--- /dev/null
+++ b/SPLICE/NEWS.md
@@ -0,0 +1,10 @@
+# SPLICE
+
+# SPLICE 1.0.1
+
+## New features {#new-features-1.0.1}
+
+## Minor improvements and fixes {#bugfixes-1.0.1}
+
+* Updates `claim_majRev_size` default to work with more than 3 major revisions
+
diff --git a/SPLICE/R/features_09_major_revisions.R b/SPLICE/R/features_09_major_revisions.R
index e5fc8fd..b39c76d 100644
--- a/SPLICE/R/features_09_major_revisions.R
+++ b/SPLICE/R/features_09_major_revisions.R
@@ -359,7 +359,7 @@ claim_majRev_time <- function(
       payment_delays <- payment_delay_list[[i]][[j]]
       no_pmt <- length(payment_delays)
       majRev_list[[i]][[j]]$majRev_atP <- ifelse(
-        majRev_list[[i]][[j]]$majRev_time[k] == sum(payment_delays[1:(no_pmt - 1)]),
+        k > 0 && majRev_list[[i]][[j]]$majRev_time[k] == sum(payment_delays[1:(no_pmt - 1)]),
         1, 0)
 
       curr <- curr + 1
@@ -456,7 +456,7 @@ claim_majRev_size <- function(
         majRev_factor[2] <- stats::rlnorm(n = 1, meanlog = 1.8, sdlog = 0.2)
         if (n > 2) {
           mu <- 1 + 0.07 * (6 - majRev_factor[2])
-          majRev_factor[3] <- stats::rlnorm(n = 1, meanlog = mu, sdlog = 0.1)
+          majRev_factor[3:n] <- stats::rlnorm(n = n - 2, meanlog = mu, sdlog = 0.1)
         }
       }