Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design] Refactor code deps org. for core data structures (trees, hashes, core types) #75

Open
hadjiszs opened this issue Feb 28, 2025 · 0 comments

Comments

@hadjiszs
Copy link
Contributor

hadjiszs commented Feb 28, 2025

This seems to be copied from pessimistic-proof-core's LocalExitTree, so I haven't reviewed in-depth the folder. This being said, I'm thinking we may want to refactor code some more to avoid duplication, and have pessimistic-proof-core probably import the types from here. However, it does mean that this crate would become as frozen as pessimistic-proof, because we don't want the pessimistic proof to change randomly.

In particular, i do think that with the recent huge increase in deps here, this could not reasonably be reused by pessimistic-proof-core. I guess the real dependency we'd want is aggchain-proof-core -> pessimistic-proof-core, but so long as it lives in the same cargo workspace as agglayer it'll be hard to do.

I guess this needs some input from other people, eg. @hadjiszs / @Freyskeyd?

Originally posted by @Ekleog-Polygon in #57 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant