-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add region flag #90
add region flag #90
Conversation
Okay update here, I've made the image available and public in the following regions:
We should add a check that the given region is in one of the supported regions. This also makes https://github.com/agentsea/agentdesk/blob/main/agentdesk/vm/img.py#L20 this ami ID invalid. We will need to update https://github.com/agentsea/agentdesk/blob/main/agentdesk/vm/ec2.py#L69 to fetch the ami ID by image name, something like: import boto3
def find_ami_by_name(ami_name, region):
ec2_client = boto3.client('ec2', region_name=region)
response = ec2_client.describe_images(
Filters=[
{
'Name': 'name',
'Values': [ami_name]
}
]
)
images = response.get('Images', [])
if not images:
print(f"No AMI found with the name: {ami_name}")
return None
# Assuming the first image in the response is the desired one
ami = images[0]
return ami The ami name is |
Ok - I can add those changes. Can we make it available on |
sorry yes here is the correct list |
Just to confirm: |
yep |
Interesting - it looks like the ID hasn't changed:
Anyway - opened agentsea/agentdesk#26 for the validation. |
Bumped |
Lint will fail until we can run the poetry lock with the new agentdesk version btw. |
|
done - @pbarker let's 🚢 :) |
depends on: agentsea/agentdesk#26