Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Improvment #9

Closed
AnisTaluqdar opened this issue Feb 28, 2022 · 15 comments
Closed

Some Improvment #9

AnisTaluqdar opened this issue Feb 28, 2022 · 15 comments

Comments

@AnisTaluqdar
Copy link

Thanks for your project.
I wish to have,

  1. Back button
  2. Home button
  3. Open document in main tab instead of new window
  4. Option for hide menu bar
@agam778
Copy link
Owner

agam778 commented Feb 28, 2022

Hi 👋🏻 Thanks for opening this issue.

I have just implemented what you said. And the Back and Home button is under an App Menu called "Navigation", because I cannot add a url bar type thing in electron.

Here is a preview: GIF Link

Please tell if it's fine so I can release the new build :)

@AnisTaluqdar
Copy link
Author

@agam778 Thank you so much. for quick fix.

It's very fine. the opening theme can be more standard. I have problem with appimage icon. the appimage icon is not working.

@agam778
Copy link
Owner

agam778 commented Feb 28, 2022

the opening theme can be more standard

You mean the thing it shows while loading at the first launch right?

the appimage icon is not working.

I'll have to test it. Give me some time

@AnisTaluqdar
Copy link
Author

AnisTaluqdar commented Feb 28, 2022

You mean the thing it shows while loading at the first launch right?
Yes

@agam778
Copy link
Owner

agam778 commented Feb 28, 2022

Oh yes, the AppImage icon is broken even for me. I'll try to fix
Btw what linux distro you are on?

@agam778
Copy link
Owner

agam778 commented Feb 28, 2022

So I tried to fix, but can't test atm as I just have Gentoo installed right now and it doesn't have some stuff.

Well, you can try installing appimaged daemon as mentioned here - electron-userland/electron-builder#748

I'll release the new build soon

@agam778
Copy link
Owner

agam778 commented Feb 28, 2022

Released - https://github.com/agam778/MS-Office-Electron/releases/tag/v0.5.0
Please check if everything's correct :)

@AnisTaluqdar
Copy link
Author

Hide menu bar not working. it's just hide whenever you press ALT otherwise by default it always show the menu bar

@agam778
Copy link
Owner

agam778 commented Feb 28, 2022

Hide menu bar not working. it's just hide whenever you press ALT otherwise by default it always show the menu bar

You'll have to just click alt once to hide it (it was even working when I opened any other website like Word), then it will be hidden anywhere. Electron's behaviour

@AnisTaluqdar
Copy link
Author

but if you re open the app. it shows menu bar and you need to hide by pressing ALT

@agam778
Copy link
Owner

agam778 commented Feb 28, 2022

Hides for me when I click anywhere in the window 🤷🏻‍♂️

MS-Office-Electron_zSfy2JtiMY

@AnisTaluqdar
Copy link
Author

hmm, it's hide automatically after when i hide and un hide window after reopening app.

@agam778
Copy link
Owner

agam778 commented Feb 28, 2022

hmm, it's hide automatically after when i hide and un hide window after reopening app.

Yep, probably the menu bar is focused when the app is launched.

@AnisTaluqdar
Copy link
Author

and command ALT already used for Excel menu bar. when I open excel and press the ALT it select the excel menu instead of top app bar.

@agam778
Copy link
Owner

agam778 commented Feb 28, 2022

Please turn off Override Shortcuts

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants