Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd reference syntax #11

Closed
afscrome opened this issue Sep 29, 2015 · 1 comment
Closed

Odd reference syntax #11

afscrome opened this issue Sep 29, 2015 · 1 comment

Comments

@afscrome
Copy link
Owner

The following is valid in NVelocity, but looks like it should be a syntax error. This is causing problems with the Antlr based parser. Investigate / decide whether this is a bug in nvelocity, and if we should maintain backwards comparability.

#set($x = 123)
#set($y = $$x)
#set($z = #$x)

$x || $y ||$z

Expected: 123 ||  ||  
Actual:   123 || 123 || 123
@afscrome
Copy link
Owner Author

afscrome commented Oct 8, 2015

This could be quite difficult to fix. Currently with the ANTLR parser, References are parsed the same way in text & argument modes. However with nvelocity, the textual string #$x is treated as a textual # followed by $x. That means we'd need different handling in the parser for references between. Won't fix.

@afscrome afscrome closed this as completed Oct 8, 2015
@afscrome afscrome added this to the 1.0 milestone Dec 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant